99 mweb component for single stats #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…nto 99-mweb-component-for-single-stats
fractaljs
reviewed
Aug 7, 2025
| titleIcon: { | ||
| width: foundationToken.unit[20], | ||
| height: foundationToken.unit[20], | ||
| marginBottom: foundationToken.unit[16], |
| fontSize: foundationToken.font.size.body.md.fontSize, | ||
| fontWeight: foundationToken.font.weight[500], | ||
| helpIcon: { | ||
| width: '16px', |
There was a problem hiding this comment.
Dont use hardcoded values, refer to FOUNDATION_TOKENS
| marginLeft: foundationToken.unit[8], | ||
| arrow: { | ||
| width: '14px', | ||
| height: '14px', |
| line: { | ||
| strokeWidth: 2, | ||
| activeDot: { | ||
| radius: 4, |
| fontWeight: foundationToken.font.weight[500], | ||
| color: foundationToken.colors.gray[400], | ||
| bar: { | ||
| radius: [2, 2, 0, 0], |
There was a problem hiding this comment.
hardcoded value use foundationToken like
${foundationTokens.units[2]}px ${foundationTokens.units[2]}px 0 0
| arrow: { | ||
| width: '14px', | ||
| height: '14px', | ||
| marginRight: foundationToken.unit[2], |
| }, | ||
| bar: { | ||
| radius: [2, 2, 0, 0], |
fractaljs
reviewed
Aug 7, 2025
| line: { | ||
| strokeWidth: toPixels(foundationToken.unit[2]), | ||
| activeDot: { | ||
| radius: toPixels(foundationToken.unit[4]), |
There was a problem hiding this comment.
I am not sure if this is needed, type casting is enough here. If not we would have to use toPixels() everywhere -- which clearly we are not doing.
| toPixels(foundationToken.unit[2]), | ||
| toPixels(foundationToken.unit[0]), | ||
| toPixels(foundationToken.unit[0]), | ||
| ], |
fractaljs
approved these changes
Aug 7, 2025
dkrai04
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added mweb support for stat cards with responsive tokens
Affected Scope
@blend/*)apps/docs)Changes Made
Added mweb support for stat cards with responsive tokens
Added maxDropDown height for dropdown input
Added inline support for select and multiselect
How to Test
Screenshots (if applicable)
| Before | After |
|
Screen.Recording.2025-08-06.at.9.00.34.PM.mov
| ----- |
|
Screen.Recording.2025-08-07.at.3.27.03.PM.mov
|
Related Issues
Closes #99
#201
#202