Skip to content

Conversation

@ellisonbg
Copy link
Contributor

This is the server side change that goes with this commit:

jupyterlab/jupyterlab@daa7afe

The idea is to replace the default workspace string 'default' with char code 0 to avoid conflicts with user defined workspaces.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2020

Codecov Report

Merging #112 into master will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   60.43%   60.39%   -0.05%     
==========================================
  Files          19       19              
  Lines        1466     1467       +1     
==========================================
  Hits          886      886              
- Misses        580      581       +1     
Impacted Files Coverage Δ
jupyterlab_server/handlers.py 53.27% <50.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b67bd...aecb41d. Read the comment docs.

@afshin
Copy link
Member

afshin commented Aug 10, 2020

Okay I think what is missing is modifying the workspaces_handler.py file as well. But this raises a question of what the REST endpoint URL for the default workspace needs to be. I think maybe going with this null character approach means we need a special URL specifically for the default workspace.

@ellisonbg
Copy link
Contributor Author

Talked to @afshin today and we believe it is best to stick with the default string - closing this PR.

@ellisonbg ellisonbg closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants