-
Notifications
You must be signed in to change notification settings - Fork 378
Improve Diff #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Diff #900
Conversation
0b17051 to
8ad6e6a
Compare
45afb08 to
2d12d07
Compare
|
❤️ 🚀 |
|
@meeseeksdev backport to jlab-2 |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Fixes #666
The diff components are back to pure Lumino widget. This suppresses the current complexity of putting non-react code (nbdime and codemirror) in react in lumino panel. And reduce code duplication with nbdime for easier maintenance.
The new structure use really the diff provider registry. And implementing file comparison with the new widget is easy (new internal command gitShowDiff that takes a
DiffModelas argument).TODO
[x] Connect settings and code mirror in plain text diffThis PR addresses also: