Skip to content

Use custom error dialogs for all Git errors #670

@ianhi

Description

@ianhi

Description

follow-up of #619

The jupyterlab provided showErrorMessage is nice because it is consistent with the rest of the application and is always available. However I think that it is generally not expressive enough for showing git related error messages. These error messages generally have some structure to them when they are present by the git CLI, for example git pull:

image
but with showErrorMessage it is impossible to retain this structure and the message ends up all squashed together:
image

The other case where this comes up is listing files that have merge conflicts. In that case it is nice to visually separate the list of files from the rest of the error message.

Would it be beneficial to have a custom error message template for all these case, or is it fine to fix them all individually using showDialog?

List of error dialogs that could be improved:

Push and pull:

Failed pull:
image

could offer a button in the dialog to run the set-upstream-to command
push:
image
vs:
image

Unlike pull this is an edited version of the error text that git generates. Would be nice to prompt that a remote needs to be added.

revert commit failure:

image

failed clone:
I think the 'fatal' isn't helpful in the context of an error message, if anything it could add confusion
image

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions