Translation missing

[fcollonval]

Translation missing for file status in

https://github.com/MLH-Fellowship/jupyterlab-git/blob/489ac202af15bb262107dcfe54728f78486818d7/src/components/FileItem.tsx#L140

Originally posted by @krassowski in #980 (comment)

• codemirror merge addon -> needs to define phrases for phrase(<string>) calls in mergeview.
• nbdime

[krassowski]

• Git clone button
  

  jupyterlab-git/src/widgets/gitClone.tsx

  Line 36 in 9df3562

  tooltip={'Git Clone'}

• Set Up Remotes and Git Documentation in git menu
  no idea why this does not work
• "Git" menu label
  

  jupyterlab-git/src/commandsAndMenu.tsx

  Line 1041 in b4876a4

  menu.title.label = 'Git';

• diff ("HEAD", "REMOTE") - nbdime

[fcollonval]

Thanks for going through the code @krassowski

[krassowski]

Should we tag it a good first issue? Edit: maybe after splitting the easier tasks like the Git button out?

[fcollonval]

Should we tag it a good first issue? Edit: maybe after splitting the easier tasks like the Git button out?

I'll tag the full issue and I help any contributors even it only partially solve the task.

[my-acc-gh]

hello @fcollonval, can I work on this?

[fcollonval]

hello @fcollonval, can I work on this?

Sure don't hesitate to open a PR early for discussion or if you need help.

[kostyafarber]

Will try work on this is, if @my-acc-gh work has stalled.

[kostyafarber]

• Git clone button
  

  jupyterlab-git/src/widgets/gitClone.tsx

  Line 36 in 9df3562

  tooltip={'Git Clone'}

• Set Up Remotes and Git Documentation in git menu
  no idea why this does not work
• "Git" menu label
  

  jupyterlab-git/src/commandsAndMenu.tsx

  Line 1041 in b4876a4

  menu.title.label = 'Git';

• diff ("HEAD", "REMOTE") - nbdime

Looks like it's also missing for "Git" menu label at:

jupyterlab-git/src/commandsAndMenu.tsx

Line 1508 in 3221c3e

gitMenu.title.label = 'Git';

[kostyafarber]

@krassowski found the reason

Set Up Remotes and Git Documentation in git menu

Didn't work. It's here:

jupyterlab-git/src/index.ts

Lines 198 to 201 in 3221c3e

	if (app.version.split('.').slice(0, 2).join('.') < '3.1') {
	// Support JLab 3.0
	mainMenu.addMenu(createGitMenu(app.commands, trans), { rank: 60 });
	}

If I move what's inside the if block outside the if block it applies the translation (and also a small text change I made to test).

Not sure the mechanics of how this works because the submenu still get's produced either way (but in the if block the translation doesn't fire).

I'm not exactly sure why that if block is there but it looks like it's checking for jlab versions less than 3.0? Don't know the purpose of that here or why it's important but any ideas on a workaround/refactor?

[fcollonval]

In JupyterLab 3.2 there is a new way of defining menus to make them customizable by the users. For that the menus need to be define in the settings schema:

jupyterlab-git/schema/plugin.json

Line 82 in 3221c3e

"jupyter.lab.menus": {

We try to be smart about those menus items to extract the strings requiring translation. But for the two of interests here, it is not straightforward as they are args:

jupyterlab-git/schema/plugin.json

Lines 148 to 155 in 3221c3e

	"text": "Set Up Remotes",
	"url": "https://www.atlassian.com/git/tutorials/setting-up-a-repository"
	}
	},
	{
	"command": "git:open-url",
	"args": {
	"text": "Git Documentation",

I guess the fix is to change that line:

jupyterlab-git/src/commandsAndMenu.tsx

Line 237 in 3221c3e

label: args => args['text'] as string,

-    label: args => args['text'] as string,
+    label: args => trans.__(args['text'] as string),

And fix the internationalization settings as described in the documentation by adding to the schema:

"jupyter.lab.internationalization": {
    "selectors": [
        "jupyter.lab.menus/.*/args/text",
    ],
    "domain": "jupyterlab_git"
}