-
-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
Description
I got a bit lost by the inheritance structure while reviewing this. We have
IChatModel, then we haveChatModelimplementing that interface (defined in@jupyter/chat), and then we haveLabChatModelextendingChatModelinjupyterlab-chat.
As a reviewer, I was confused about why the Jupyter Chat project provides two implementations of
IChatModel.
It seems like
ChatModelin@jupyter/chatshould be an abstract base class, andChatModelshould be renamed toAbstractChatModel. This would help make the inheritance structure more obvious. What are your thoughts on this?
Originally posted by @dlqqq in #148 (comment)
Metadata
Metadata
Assignees
Labels
No labels