-
Notifications
You must be signed in to change notification settings - Fork 381
Add base environment for Python 3.13 #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The missing package, Can I have some help to know where this package is created? Thanks! |
I think this is the problem. jupyter-resource-usage requires psutil<6 which isn't built for python 3.13 |
I contacted the developers of |
Related to jupyterhub#1446
using freeze.py script
01cc59b to
1269dd2
Compare
|
@minrk can I have some help to understand why the test https://github.com/jupyterhub/repo2docker/blob/main/tests/venv/default/verify is failing here? |
- switch to simpler jupyter-keepalive extension - set -e in postBuild to catch errors - set -x to see steps as they go for easier debugging
|
I think I fixed it. I believe it was the fact that jupyter-collaboration is no longer the name of the actual server extension package, it is now jupyter_server_ydoc. I switched it to a simpler extension that isn't going to have similar refactors, and added better output to both postBuild and verify to hopefully make it easier to see what's wrong |
minrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved now that tests are passing, but I'll leave it to you to merge since this is still a draft.
|
Thanks Min for the fix. I will go ahead and merge now that all tests are passing. |
Please do NOT merge this yet.
The creation of the conda environment for Python 3.13 is failing with the following log