Improve performance of fix-permissions script #1776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Using the
-exec command {} +(instead of;) action offind, we can improve the performance of fix-permissions script significantly. The difference between the two is that the former (+) invokes a single process and passes all the files to it as arguments, whereas the latter (;) invokes one process per matched file resulting in thousands ofchmodruns per build.My benchmarks show about a 30 second improvement in steps that involve fix-permissions for the
build-alltarget ofmake. More importantly for me, user defined Docker images, which use the fix-permissions script, will also show perf improvements.Issue ticket if applicable
n/a
Checklist (especially for first-time contributors)