-
Notifications
You must be signed in to change notification settings - Fork 3k
Update mypy config and make it work well with pre-commit #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mypy config and make it work well with pre-commit #1646
Conversation
|
Unfortunately, |
If we cant use if with pre-commit then that is also relevance to clarify in the file as a comment/fixme preferably linking out to something relevant to track if its to be fixed over time - a github issue in this or upstream repo. |
If it doesn't work the same way, and it's not of importance if we choose way A or B but what is important is that we are consistent, I suggest we stick with anything that can be done with pre-commit instead of sticking with an option that requires manual intervention etc. I've not read up on mypy or what it does though or what difference there are etc. |
|
@consideRatio thank you for very good suggestions. Please, take a look and tell me what you think. |
consideRatio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful @mathbunnyru! Thanks for being so thorough with the transition to make this code typed, with all this setup I think this repo is really set to maintain typings!!! ❤️ 🎉
What I've done:
--strict --follow-imports error. This makes this tool much more efficient in finding errors.pre-commitmypy hook use the same configpre-commithook works well and disabledmypyforgit commitstage