Skip to content

Conversation

@jravenel
Copy link
Contributor

@jravenel jravenel commented Oct 6, 2025

Resolves #626

Changes

  • Auto-starts API and MCP servers in background when running make local-up
  • Reuses existing make api and make mcp-http commands
  • Shows service URLs in startup message

Result

🌟 Local environment ready!
✓ Services available at:
  - Oxigraph (Knowledge Graph): http://localhost:7878
  - YasGUI (SPARQL Editor): http://localhost:3000
  - PostgreSQL (Agent Memory): localhost:5432
  - Dagster (Orchestration): http://localhost:3001
  - Docker Models (Airgapped AI): ai/gemma3 ready via 'docker model run'
  - API: http://localhost:9879
  - MCP Server: http://localhost:8000/sse

- Reuses existing 'make api' and 'make mcp-http' commands
- Starts both in background with PID tracking
- Shows API and MCP URLs in startup message
- Cleans up processes in local-down/local-stop/local-clean

Resolves #626
@jravenel jravenel requested a review from Dr0p42 October 6, 2025 20:58
- Skip queries with arguments when argument loading is disabled
- Prevents KeyError when accessing arguments[argument]
- Fixes API startup crash and CI/CD test failures
@jravenel jravenel force-pushed the 626-start-api-and-mcp-server-when-make branch from 1b0e712 to 8d209f3 Compare October 6, 2025 21:08
@jravenel
Copy link
Contributor Author

jravenel commented Oct 6, 2025

Bug found:
The code loads SPARQL queries from the knowledge graph that can have arguments (parameters)
The code that loads those arguments was commented out (disabled) - so the arguments dictionary was empty
But the code that builds tools from those queries still tried to access arguments[argument] for each query
Result: Crashed with KeyError because it tried to look up arguments that were never loaded

Fix:
Added a filter to only use arguments that actually exist in the arguments dict - if an argument isn't loaded, skip it instead of crashing.

jravenel added 2 commits October 6, 2025 23:16
- Changed 'Artificial Business Intelligence' to 'Agentic Brain Infrastructure'
- Updated API documentation and agent description
- Changed 'Artifical Business Intelligence' to 'Agentic Brain Infrastructure'
- Fixed typo (Artifical -> Agentic)
- Updated both config.yaml and config.yaml.example
@jravenel
Copy link
Contributor Author

jravenel commented Oct 6, 2025

@Dr0p42 ready for review

@jravenel jravenel self-assigned this Oct 6, 2025
@Dr0p42
Copy link
Contributor

Dr0p42 commented Oct 22, 2025

I think that we should instead have those started and running as docker container to keep it simple @jravenel

@jravenel
Copy link
Contributor Author

good for me @Dr0p42, does it change the description above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start API and MCP server when make

3 participants