Skip to content

Conversation

@odow
Copy link
Member

@odow odow commented Apr 11, 2023

No description provided.

@odow
Copy link
Member Author

odow commented Apr 11, 2023

Took me a while to figure out why formatting broke tests:

image

That's not a valid rewrite!

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 90.67% and project coverage change: +0.35 🎉

Comparison is base (ff1a376) 87.57% compared to head (fd44234) 87.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   87.57%   87.92%   +0.35%     
==========================================
  Files          11       11              
  Lines        1006     1052      +46     
==========================================
+ Hits          881      925      +44     
- Misses        125      127       +2     
Impacted Files Coverage Δ
src/DiffOpt.jl 100.00% <ø> (ø)
src/bridges_unused.jl 0.00% <0.00%> (ø)
src/objective_container.jl 0.00% <ø> (ø)
src/moi_wrapper.jl 87.14% <85.00%> (+0.60%) ⬆️
src/jump_moi_overloads.jl 80.67% <85.10%> (+0.85%) ⬆️
src/ConicProgram/ConicProgram.jl 93.79% <96.15%> (+0.08%) ⬆️
src/QuadraticProgram/QuadraticProgram.jl 98.05% <96.55%> (+0.02%) ⬆️
src/bridges.jl 96.22% <100.00%> (ø)
src/diff_opt.jl 98.54% <100.00%> (+0.06%) ⬆️
src/product_of_sets.jl 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blegat blegat merged commit 190beb8 into master Apr 11, 2023
@odow odow deleted the od/format branch April 12, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants