Minio + pre-signed urls #431
Open
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
pushed a commit
to nextcloud/server
that referenced
this pull request
Nov 10, 2025
This is faster than going back to nextcloud to download the files. This is an opt-in setting that can be enabled by setting use_presigned_url in the object store config. Additionally add support for the proxy config which is needed in a docker setup. See juliusknorr/nextcloud-docker-dev#431 Signed-off-by: Carl Schwan <[email protected]>
6 tasks
CarlSchwan
pushed a commit
to nextcloud/server
that referenced
this pull request
Nov 12, 2025
This is faster than going back to nextcloud to download the files. This is an opt-in setting that can be enabled by setting use_presigned_url in the object store config. Additionally add support for the proxy config which is needed in a docker setup. See juliusknorr/nextcloud-docker-dev#431 Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/minio
branch
from
6ff9ff4 to
479f23b
Compare
CarlSchwan
pushed a commit
to nextcloud/server
that referenced
this pull request
Nov 12, 2025
This is faster than going back to nextcloud to download the files. This is an opt-in setting that can be enabled by setting use_presigned_url in the object store config. Additionally add support for the proxy config which is needed in a docker setup. See juliusknorr/nextcloud-docker-dev#431 Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
pushed a commit
to nextcloud/server
that referenced
this pull request
Nov 12, 2025
This is faster than going back to nextcloud to download the files. This is an opt-in setting that can be enabled by setting use_presigned_url in the object store config. Additionally add support for the proxy config which is needed in a docker setup. See juliusknorr/nextcloud-docker-dev#431 Signed-off-by: Carl Schwan <[email protected]>
juliusknorr
requested changes
Nov 12, 2025
Owner
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Thanks for adding that (also the server implementation) however there seem to be a few unrelated changes in the commits. Can you extract that to only have the s3 related changes in this pr?
| volumes: | ||
| - mysql:/var/lib/mysql | ||
|
|
||
| database-vitess: |
Owner
There was a problem hiding this comment.
Curious about your attempts with that but rather unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.