Skip to content

fix: use fully qualified domain for container images #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use fully qualified domain for container images #388

wants to merge 1 commit into from

Conversation

@ZephOne
Copy link

@ZephOne ZephOne commented Mar 5, 2025

Fix #387

@ZephOne ZephOne marked this pull request as draft March 5, 2025 10:55
@ZephOne ZephOne closed this Mar 5, 2025
@juliusknorr
Copy link
Owner

juliusknorr commented Mar 5, 2025

This is still a nice step i think. Let me reopen to get that merged

@juliusknorr juliusknorr reopened this Mar 5, 2025
@ZephOne
Copy link
Author

ZephOne commented Mar 5, 2025

This is still a nice step i think. Let me reopen to get that merged

Okay, but wait, I need to add docker.io in "FROM" instruction in docker/Dockerfile* and docker/*/Dockerfile

@ZephOne ZephOne force-pushed the use-fully-qualified-domain-for-container-images branch from 2de9404 to 31ce3ef Compare March 5, 2025 16:15
@ZephOne ZephOne marked this pull request as ready for review March 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use fully-qualified domain for containers image

2 participants

@ZephOne @juliusknorr