-
Notifications
You must be signed in to change notification settings - Fork 93
Create script to create aliases file #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create script to create aliases file #347
Conversation
|
@juliusknorr this PR is quite old. Would we better close this or try to get this merged? Is i to invasive? Just give me your impression, then I can prepare this accordingly. |
|
I'm not sure if this is too much magic and we should rather just document useful aliases, what do you think? |
|
Yeah, generally, this can be put to the docs as well. In any case, there needs to be something in the docs on how to install the alias file. One point is that this will not auto-update over time if done in the docs (the users will not redo it regularly). When it is just linked/sourced, we could change the alias definitions in case the aliases change (e.g. conversion to function etc). Just out of maintenance perspective. |
|
RIght, with a way to update that is certainly nice. The code itself seems good, then we can get it merged form my side once we have a short documentation addition. |
|
So, my next tasks as rebase, write docs and ping you again. Correct? Then, I would go this route (just wanted to confirm this to avoid unnecessary work in general). |
|
Yes, that would be much appreciated. :) Thanks already and sorry for the delay with checking out. |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
afff757 to
5d6adc2
Compare
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
|
@juliusknorr I added some documentation. Do you think this is sufficient or do we need more? I tried to add Just give me a shot notice. Thanks! |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
This will create an aliases file that can be sourced in the
.bashrc. It can be seen as a draft idea and extended as needed.