Used typed `app` object

[christian-byrne]

• Add @comfyorg/comfyui-frontend-types as dev dependency
• @comfyorg/comfyui-frontend-types declares window.app and also exposes comfyApp type
• Access typed version of the app object

[jtydhr88]

I don't think this approach is bad - in fact, I think it might be the 'more correct' way to reference window.app.

However, I'd like to discuss this from a technical perspective.
Comparing the code before and after the changes, we can see that previously, when using import { app } from "../../../scripts/app.js", developers could directly call app.registerExtension.

But now, if using the approach with:

import { ComfyApp } from '@comfyorg/comfyui-frontend-types'
declare global {
  interface Window {
    app?: ComfyApp
  }
}

developers need to write their own code to check whether window.app has been successfully initialized, just like what you or I am doing on our React and Vue template.

Furthermore, for my Vue application or other projects that need to call import { addWidget, ComponentWidgetImpl } from "../../../scripts/domWidget.js", since these are not exposed in comfyui-frontend-types, I still need to use the "../../../scripts/domWidget.js" style import for the two methods I need: addWidget and ComponentWidgetImpl.

This seems to contradict our goal of having frontend developers use a unified comfyui-frontend-types approach.

So I'd like to discuss this issue from a technical standpoint - how do you think about this?

[christian-byrne]

That makes sense. What about just

import { app } from "../../../scripts/app.js";

const comfyApp: ComfyApp = app;

[jtydhr88]

it works @christian-byrne
full code likely is

import { app } from "../../../scripts/app.js";
import { ComfyApp } from '@comfyorg/comfyui-frontend-types'
const comfyApp: ComfyApp = app;
comfyApp.registerExtension({
    name: 'vue-basic',
});

please check my latest commit in this PR #13.
do you prefer to this or previous one that needs to check app initialized manually?

[christian-byrne]

That seems better, rather than waiting for app to initialize manually.