[Test] parsers.all augments suggestion code output #3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Dec 11, 2021
ljharb
changed the title
Contributor
Author
👍 I'll update the commit message when I squash this. |
parsers.all generates an extraComment which is appended to test case examples and their expected output. Eslint's suggestions API also allows recommended code changes, and RuleTester compares expected changes against generated changes. However, parsers.all didn't augment these expected outputs with the extraComment.
ljharb
reviewed
Dec 11, 2021
duncanbeevers
force-pushed
the
parsers-all-suggestions-extra-comment
branch
from
d159eea to
f7943d5
Compare
ljharb
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to generate suggestions for #2921 I need support for augmenting suggestions in the
parsers.allwork, to ensure my spec examples get decorated with theextraComment.🗣 Discussion
parsers.all generates an
extraCommentwhich is appended to test case examples and their expected output.Eslint's suggestions API also allows recommended code changes, and RuleTester compares expected changes against generated changes. However,
parsers.alldidn't augment these expected outputs with theextraComment.📋 Next steps
I intend to include these changes with the
hook-use-statePR where the utility will be more obvious, but I wanted to open discussion here in case my approach needs to be refined, and to keep the already long-runninghook-use-statePR focused.