Skip to content

Conversation

@Schweinepriester
Copy link
Contributor

Checked the links, corrected them and skipping the redirect HTTP => HTTPS this way 0:-)

For convenience:

… want me to check and change the rest as well? :)

@ljharb
Copy link
Member

ljharb commented Nov 12, 2021

Yes, we might as well change them all at once.

@ljharb ljharb marked this pull request as draft November 13, 2021 16:47
@Schweinepriester
Copy link
Contributor Author

There we go, should have got them all.

Not sure about the failing pipeline…? Is there anything I can do?

I'm not totally sure about http://facebook.github.io/react/docs/more-about-refs.html#the-ref-callback-attribute => https://reactjs.org/docs/refs-and-the-dom.html#callback-refs, might want to have a look, but I think it's the correct one :)

I assume you were going to do that anyway, but given my commits and messages, I'd recommend squashing 0:-)

@Schweinepriester Schweinepriester marked this pull request as ready for review January 1, 2022 16:11
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, and converted the remaining http links to https in the codebase.

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2022

Codecov Report

Merging #3133 (151bb2b) into master (ccf3c35) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3133   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         120      120           
  Lines        8265     8265           
  Branches     2975     2975           
=======================================
  Hits         8062     8062           
  Misses        203      203           
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 96.66% <ø> (ø)
lib/util/pragma.js 93.10% <ø> (ø)
lib/util/version.js 97.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf3c35...151bb2b. Read the comment docs.

@ljharb ljharb changed the title README.md: HTTP => HTTPS [Docs] HTTP => HTTPS Jan 1, 2022
@ljharb ljharb merged commit 151bb2b into jsx-eslint:master Jan 1, 2022
@Schweinepriester Schweinepriester deleted the patch-1 branch January 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants