[no-unused-state] Ignore computed property keys for no unused state rule #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed-state rule - unless the key is a literal
jackyho112
changed the title
jackyho112
changed the title
ljharb
reviewed
Aug 23, 2017
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
This looks awesome, thanks!
Cold you also add a template literal with no substitutions? That should work just like a string literal.
EvHaus
approved these changes
Aug 23, 2017
Collaborator
EvHaus
left a comment
EvHaus
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Contributor
Author
|
You are welcome! Look forward to doing more. |
jackyho112
deleted the
ignore-computed-property-keys-for-no-unused-state-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1361.
This sets the no-unused-state rule to ignore computed property keys when the contents aren't literal.
I think it should cover all kinds of literals for checking unused state properties because it could happen in types other than string and could be checked. If that is undesirable, I could change it to only checking string literals.
Other than that, let me know what other improvements you have in mind.