Skip to content

Fix ignorePureComponents when using class expressions. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 15, 2017
Merged

Fix ignorePureComponents when using class expressions. #1122

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3266ab6
prefer-stateless-function w/ decorators
benstepp Feb 23, 2017
557322a
Fix nextProps false positive in no-unused-prop-types
Kerumen Mar 9, 2017
4e8e86a
Fix ignorePureComponents when using class expressions.
dreid Mar 23, 2017
f35c03c
Fix indentation in no-unused-prop-types example.
dreid Mar 28, 2017
9a5303d
Merge pull request #1106 from Kerumen/master
ljharb Mar 31, 2017
7111a70
Merge pull request #1130 from dreid/patch-1
ljharb Mar 31, 2017
877e6dc
Add no-will-update-set-state rule
Apr 5, 2017
58519ae
Factor out no-<method>-set-state rule code to a utility
Apr 6, 2017
4405523
Fix util filename in require
Apr 6, 2017
0ae6bb2
Merge pull request #1139 from amplitude/no-will-update-set-state
ljharb Apr 9, 2017
5f893e5
corrects all the .eslintrc examples in the docs directory
Adzz Apr 12, 2017
24ea6f3
Merge pull request #1149 from Adzz/patch-1
lencioni Apr 13, 2017
cdfc508
Link fix: ReactDOM docs were broken out
Apr 13, 2017
82648f3
Merge pull request #1151 from MatthewHerbst/link-fix/no-render-return…
lencioni Apr 13, 2017
fd90dae
Merge pull request #1086 from benstepp/bs-stateless-decorators
lencioni Apr 14, 2017
a2b61ed
Merge branch 'master' into allow-wrapped-pure-components
dreid Apr 18, 2017
0fac8d9
Update prefer-stateless-function.js
dreid Apr 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions lib/rules/prefer-stateless-function.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,15 @@ module.exports = {
});
}

function visitClass(node) {
if (ignorePureComponents && utils.isPureComponent(node)) {
markSCUAsDeclared(node);
}
}

return {
ClassDeclaration: function (node) {
if (ignorePureComponents && utils.isPureComponent(node)) {
markSCUAsDeclared(node);
}
},
ClassDeclaration: visitClass,
ClassExpression: visitClass,

// Mark `this` destructuring as a usage of `this`
VariableDeclarator: function(node) {
Expand Down Expand Up @@ -386,7 +389,6 @@ module.exports = {
if (list[component].hasSCU && list[component].usePropsOrContext) {
continue;
}

context.report({
node: list[component].node,
message: 'Component should be written as a pure function'
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-stateless-function.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,19 @@ ruleTester.run('prefer-stateless-function', rule, {
options: [{
ignorePureComponents: true
}]
}, {
// Extends from PureComponent in an expression context.
code: [
'const Foo = class extends React.PureComponent {',
' render() {',
' return <div>{this.props.foo}</div>;',
' }',
'};'
].join('\n'),
parserOptions: parserOptions,
options: [{
ignorePureComponents: true
}]
}, {
// Has a lifecyle method
code: [
Expand Down