Skip to content

fix error inserts generated in functions #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2019
Merged

fix error inserts generated in functions #341

merged 2 commits into from
Jun 28, 2019

Conversation

@andrew-coleman
Copy link
Member

@andrew-coleman andrew-coleman commented Jun 28, 2019

The tail-call trampolining code was masking the true location (position & token) of the error.

resolves #297

@coveralls
Copy link

coveralls commented Jun 28, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a0a71fe on fix_297 into 200dbac on master.

@coveralls
Copy link

coveralls commented Jun 28, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling aef4286 on fix_297 into afe903c on master.

@mattbaileyuk mattbaileyuk merged commit 06a6b75 into master Jun 28, 2019
@mattbaileyuk mattbaileyuk deleted the fix_297 branch June 28, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbaileyuk mattbaileyuk mattbaileyuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading error message for error in function body

4 participants

@andrew-coleman @coveralls @mattbaileyuk