Fix performance regression #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
mattbaileyuk
reviewed
Jan 7, 2019
| describe("$now() returns timestamp with defined format", function() { | ||
| it("should return result object", function() { | ||
| var expr = jsonata("$now('[h]:[M][P] [z]')"); | ||
| var expr = jsonata("$now('[h]:[M01][P] [z]')"); |
Member
There was a problem hiding this comment.
I believe this is unrelated to the rest of the fixes, but agree with the change so not too worried that it's here.
mattbaileyuk
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #247 introduced a significant performance regression.
This PR rewrites that bit of code to recover the loss.