add a name to the copyright, and add some type mismatch cases to the tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks :). I put some line notes in the commits. |
Julian
pushed a commit
that referenced
this pull request
Jun 30, 2019
Straight up copy Draft 7 tests to Draft 2019-06.
big-andy-coates
added a commit
to big-andy-coates/JSON-Schema-Test-Suite
that referenced
this pull request
Jun 22, 2024
Currently, there exists an ecma regex test case that uses `"format": "regex"`. My understanding was that all tests that require format validation where implemented under the `optional/format` directory. (As per point json-schema-org#2 of https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/9fc880bfb6d8ccd093bc82431f17d13681ffae8e/README.md#additional-assumptions). As such, this change moves the test requiring `format` under the `optional/format` directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd throw this over your way to look at, even thought I haven't got it added to my validator yet.
Let me know what yout think, please.