Replace deprecated lodash.omit dependency with destructure #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was about to make the same change 🙂 Thank you @lovell |
lostunicorn-addestino
approved these changes
Sep 30, 2025
|
sounds good thanks, just setting up a new laptop but will get on it soon..
|
|
Done, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you very much for maintaining this package, we use it to convert inline JSDocs to Markdown for the sharp API documentation and it's been really useful.
I've been cleaning up and modernising sharp's (dev)dependencies and spotted use of the deprecated
lodash.omitpackage in the tree, which this PR replaces with object destructing/assignment instead.(The size of the
package-lock.jsondiff makes this change appear slightly more complex than it is. I wonder if perhaps this file should be removed/gitignored from the repo given it is not published?)