ESM support #974
Merged
ESM support #974
+258
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
force-pushed
the
ryan/fs-readv
branch
from
ccf9026 to
d0328e9
Compare
| "exports": { | ||
| ".": "./lib/index.js", | ||
| "./esm": "./lib/esm.mjs" | ||
| }, |
There was a problem hiding this comment.
Have you considered using export conditions so it automatically exports the ESM version when import is used instead of require?
"exports": {
".": {
"require": "./lib/index.js",
"import": "./lib/esm.mjs"
},
"./esm": "./lib/esm.mjs"
}
I added the ./esm in case, but this way, you may not even need the ./esm endpoint:
"exports": {
"require": "./lib/index.js",
"import": "./lib/esm.mjs"
}
There was a problem hiding this comment.
I don't want to do that, because the ESM version doesn't export normal fs methods like the CJS version does. Since it's a different feature set, it's best to be explicit. Otherwise, I'd definitely do this.
There was a problem hiding this comment.
Why the regression? Sounds it can be kept with:
export * from 'fs';There was a problem hiding this comment.
See #746 (comment)
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #970
Review commit-by-commit.
Breaking change, as it switches from
maintoexportsinpackage.json, outlawing all subpath imports except those explicitly specified.Fixes #746