Drop old Node support #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI configs
RyanZim
force-pushed
the
ryan/drop-node
branch
from
cdbcc09 to
177743c
Compare
|
Rebased and force-pushed to fix merge conflicts |
RyanZim
force-pushed
the
ryan/drop-node
branch
from
177743c to
54b70a7
Compare
|
Holding to merge after #633 |
abetomo
added a commit
to abetomo/node-lambda
that referenced
this pull request
Apr 15, 2020
Depends on 'fs-extra'. jprichardson/node-fs-extra#751
abetomo
added a commit
to abetomo/node-lambda
that referenced
this pull request
Apr 15, 2020
Depends on 'fs-extra'. jprichardson/node-fs-extra#751
DeviaVir
pushed a commit
to motdotla/node-lambda
that referenced
this pull request
Apr 15, 2020
* Upgrade packages
There was a major upgrade in some packages.
* Drop Node.js 8.x from workflow.yml
```
/home/runner/work/node-lambda/node-lambda/node_modules/fs-extra/lib/mkdirs/make-dir.js:86
} catch {
^
SyntaxError: Unexpected token {
```
* Drop old Node support
Depends on 'fs-extra'.
jprichardson/node-fs-extra#751
78 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #725. Require Node
>=10; also upgraded some code to use new language features.Will probably need rebased after #747 is merged.DoneReview commit-by-commit for your sanity.