BREAKING: fs.read() & fs.write() should return objects #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
RyanZim
force-pushed
the
read-write-obj
branch
2 times, most recently
from
28ac447 to
d3545d4
Compare
Repository owner
deleted a comment from
coveralls
Jun 26, 2017
Collaborator
Author
|
Windows CI fails due to funky windows timestamps; unrelated to this change. |
For forward-compat with util.promisify()
jprichardson
approved these changes
Jun 27, 2017
manidlou
approved these changes
Jun 27, 2017
|
@RyanZim But why does the node.js v4 build pass and the v6 build fail? |
Collaborator
Author
|
@Yamboy1 It's a 32-bit windows issue; nothing critical. |
|
@RyanZim It's reasons like this why I prefer to use Linux |
|
Windows just has too many bugs |
This was referenced Oct 19, 2017
This was referenced Oct 19, 2017
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For forward-compat with
util.promisify()Resolves #436
Needs docs yet