This repository was archived by the owner on May 4, 2018. It is now read-only.
Read console fixes #873
Closed
Read console fixes #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit MSOpenTech/libuv@b255e23704bc6d84336fe0ad2d2aa182598ef3d9 has the following error(s):
Commit MSOpenTech/libuv@16ea4b3b8ae9108dc672154b0a5603608e94f055 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
There was a problem hiding this comment.
Style: two newlines between functions.
|
Pointed out some style issues. @piscisaureus I suggest you review the technical aspect. |
Fixes NodeJS test-regress-GH-746.js and test-stdout-close-unref.js unit tests by sending a return key stroke prior to closing the handle. This forces ReadConsole to exit and allows the IO operation to complete.
fixed system library dependency so that unit tests would build from vcbuild.bat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the unit tests for Node.JS close the stdin handle. ReadConsoleA in tty.c at line 335 will not return with failure when the handle is deleted, thus causing the Node unit test to hang while waiting for IO to complete.