- 
                Notifications
    
You must be signed in to change notification settings  - Fork 16
 
Livewire v3 + README updates #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           @Edgarborras94 Thanks! I've triggered the tests to run. Not sure if they will though as I'll probably need to update then to suit v3. Re styling, generally it's better to remove style changes as it's harder for maintainers to review the code you actually changed (vs code format changes). So if it's not too hard, can you reset the styling? Also thanks for updating the readme! Will have a good look in the next couple of days 🙂 Yeah it's always nice to be able to contribute 😁  | 
    
| 
           I've removed the reformatted code I think. Also noticed I removed the package "joshhanley/livewire-dusk-testbench": "^0.1.0" because it's still not v3 compatible (I think) I will keep an eye on this topic so tell me anything you need Cheers!  | 
    
| 
           @Edgarborras94 thanks for the PR! Sorry it took me a while to get to it. Removing the  I've got tests running now without it, using a fork of Livewire which exposes some of it's dusk testing internals, which I hope to get merged into Livewire core so package maintainers can use it. If that doesn't work, then I will update  Thanks again for your help! 😁  | 
    
Just noticed some changed are from my formatter lmao, sorry about that @joshhanley (:
Changed also the readme to include an example of the add new event we talked about several months ago (better late than never ;) )
I'm glad contributing to open source as I'm getting confident with the Laravel ecosystem!!