Add option to apply python-mode fontification to input echoed to shell #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
galaunay
force-pushed
the
master
branch
4 times, most recently
from
c4a2564 to
d974e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution to PR #1698 and #1428.
PR #1698 first inserts the echoed input into the shell buffer and then fontifies it. This causes problems (1) when a continuation prompt is used and (2) when the input is truncated because it is long. In both cases, fontification may be confused.
This PR proceeds the other way around: it first fontifies the echoed input and then inserts it into the shell buffer (potentially with continuation prompt). This leads to correct formatting (for all valid Python code).