Skip to content

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

In PHP 8.4, not passing the $escape parameter emits a deprecation notice. Passing the $escape parameter explicitly avoids the deprecation notice.

Testing Instructions

Using php 8.4 go to action logs and export, Check the export

Actual result BEFORE applying this Pull Request

Deprecation notice
<b>Deprecated</b>: fputcsv(): the $escape parameter must be provided as its default value will change in <b>D:\repos\j6\administrator\components\com_actionlogs\src\Controller\ActionlogsController.php</b> on line <b>113</b><br />

Expected result AFTER applying this Pull Request

No deprecation notice

Reference https://php.watch/versions/8.4/csv-functions-escape-parameter

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
@exlemor
Copy link

exlemor commented Nov 11, 2025

I have tested this item ✅ successfully on 652f2f2

I have tested this successfully :) Thks @brianteeman for the fix!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 652f2f2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.

@richard67 richard67 added the bug label Nov 12, 2025
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PR-5.4-dev RTC This Pull Request is Ready To Commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants