-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] [Guided Tours] Fancy select fields are broken and not accessible in tours #40238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
40e65ef
Fix fancy-select fields for tags
obuisard b207e33
Add support to fancy-select fields for proper handling and accessibility
obuisard 248c7b5
Update extensions.sql
obuisard 53021c1
Update extensions.sql
obuisard 2bb2046
Update 4.3.0-2023-02-15.sql
obuisard edaf3ad
Update 4.3.0-2023-02-15.sql
obuisard d8d7b7f
Merge branch '4.3-dev' into guided-tours-fancy-select
QuyTon 271e135
Merge branch '4.3-dev' into guided-tours-fancy-select
QuyTon 4654dd9
Merge branch '4.3-dev' into guided-tours-fancy-select
obuisard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-03-29.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| UPDATE `#__guidedtour_steps` | ||
| SET `target` = 'joomla-field-fancy-select .choices' | ||
| WHERE `id` = 5; | ||
|
|
||
| UPDATE `#__guidedtour_steps` | ||
| SET `target` = 'joomla-field-fancy-select .choices[data-type=select-multiple]' | ||
| WHERE `id` IN (26,38,78,90); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.