Skip to content

Remove references to now obselete phantomJs #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove references to now obselete phantomJs #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc68329
Update world.js
tjl694 Nov 19, 2020
3c214d9
Delete phantomDriver.js
tjl694 Nov 19, 2020
6f2f599
Update README.MD
tjl694 Nov 19, 2020
a6fb520
Update package.json
tjl694 Nov 19, 2020
8430df5
Merge branch 'john-doherty:master' into patch-1
tjl694 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ Browser | Example
---------- | ---------------
Chrome | `-b chrome`
Firefox | `-b firefox`
Phantom JS | `-b phantomjs`
Electron | `-b electron`
Custom | `-b customDriver.js`

Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"fs-plus": "2.9.1",
"geckodriver": "^1.16.2",
"merge": "^1.2.1",
"phantomjs-prebuilt": "2.1.12",
"require-dir": "0.3.2",
"selenium-webdriver": "3.5.0"
},
Expand Down
23 changes: 0 additions & 23 deletions runtime/phantomDriver.js
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions runtime/world.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ var Eyes = require('eyes.selenium').Eyes;

// drivers
var FireFoxDriver = require('./firefoxDriver.js');
var PhantomJSDriver = require('./phantomDriver.js');
var ElectronDriver = require('./electronDriver.js');
var ChromeDriver = require('./chromeDriver');

Expand All @@ -40,11 +39,6 @@ function getDriverInstance() {
}
break;

case 'phantomjs': {
driver = new PhantomJSDriver();
}
break;

case 'electron': {
driver = new ElectronDriver();
}
Expand Down Expand Up @@ -252,7 +246,7 @@ module.exports = function () {
// add a screenshot to the error report
return driver.takeScreenshot().then(function (screenShot) {

scenario.attach(new Buffer(screenShot, 'base64'), 'image/png');
scenario.attach(Buffer.from(screenShot, 'base64'), 'image/png');

return teardownBrowser().then(function() {
if (eyes) {
Expand Down