Skip to content

Conversation

@lorban
Copy link
Contributor

@lorban lorban commented Oct 29, 2025

Fixes #13922

Note: those are the only (non-test) code places I found where the async context timeout isn't explicitly set.

@lorban lorban requested review from gregw and sbordet October 29, 2025 16:44
@lorban lorban self-assigned this Oct 29, 2025
@lorban lorban added the Bug For general bugs on Jetty side label Oct 29, 2025
@lorban lorban moved this to 👀 In review in Jetty 12.1.4 Oct 29, 2025
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a better comment in the test.
Please change it also in ee10.

@lorban lorban requested a review from sbordet October 29, 2025 21:39
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorban you missed one line of my proposed comment.

@lorban lorban requested a review from sbordet October 30, 2025 09:40
@lorban lorban force-pushed the fix/12.1.x/13922-ResourceServlet-AsyncContext-timeout branch from f80ff7c to cca3309 Compare November 4, 2025 14:52
@lorban lorban merged commit 76ddd6f into jetty-12.1.x Nov 5, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.1.4 Nov 5, 2025
@lorban lorban deleted the fix/12.1.x/13922-ResourceServlet-AsyncContext-timeout branch November 5, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug For general bugs on Jetty side

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

ResourceServlet Download link broken

3 participants