Issue #12720 - fix servlet error dispatch for errors generated by SecurityHandler #13693
+185
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…curityHandler Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
|
@lachlan-roberts the CI failures look to be more than flakes. |
|
@gregw the tests are failing because the So do you think i should adjust both the |
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Oct 21, 2025
jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Oct 21, 2025
jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12720
Currently
SecurityHandlerdoes onlyResponse.writeErrorwhen a 403 response needs to be sent. However this will not dispatch to a servlet error page, for this we need to doAuthenticationState.writeErrorand handle the case if it returnsAuthenticationState.ServeAs.