Refine offset, length size handling in Content.Sources #13690
+934
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #14685 by handling zero length resources
lachlan-roberts
previously approved these changes
Oct 10, 2025
sbordet
requested changes
Oct 10, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ByteChannelContentSource.java
Show resolved
Hide resolved
Fix #14685 by handling zero length resources
lorban
requested changes
Oct 10, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ByteChannelContentSource.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/test/java/org/eclipse/jetty/io/IOResourcesTest.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/test/java/org/eclipse/jetty/io/IOResourcesTest.java
Show resolved
Hide resolved
sbordet
previously approved these changes
Oct 10, 2025
sbordet
requested changes
Oct 13, 2025
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ByteChannelContentSource.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/BufferUtil.java
Outdated
Show resolved
Hide resolved
|
@gregw lots of TODO in this PR, still a work in progress? |
Signed-off-by: Lachlan Roberts <[email protected]>
…1.x/13685-zeroLengthFiles
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
commented
Oct 21, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
lorban
requested changes
Oct 23, 2025
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/test/java/org/eclipse/jetty/io/IOResourcesTest.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/TypeUtil.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/TypeUtil.java
Outdated
Show resolved
Hide resolved
lorban
approved these changes
Oct 24, 2025
lorban
requested changes
Oct 27, 2025
sbordet
requested changes
Oct 27, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/BufferUtil.java
Outdated
Show resolved
Hide resolved
…1.x/13685-zeroLengthFiles
sbordet
requested changes
Oct 28, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/ContentSourceRange.java
Outdated
Show resolved
Hide resolved
|
@sbordet I don't really agree that we should not modify the the chunk at all. But I made the changes anyway, as it should be cheap with reference counting. |
sbordet
previously approved these changes
Oct 28, 2025
Signed-off-by: Ludovic Orban <[email protected]>
lorban
previously approved these changes
Oct 28, 2025
sbordet
requested changes
Oct 28, 2025
...-core/jetty-http/src/main/java/org/eclipse/jetty/http/content/CachingHttpContentFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13685 by handling zero length resources