Fixes #3515 - Review Uptime. #13648
Merged
Fixes #3515 - Review Uptime. #13648
+49
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecated for removal Uptime. * Remove its usages, replaced by using Instant in Server. Signed-off-by: Simone Bordet <[email protected]>
Closed
…1.x/3515-remove-uptime # Conflicts: # jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Server.java
Signed-off-by: Simone Bordet <[email protected]>
joakime
previously approved these changes
Oct 27, 2025
| */ | ||
| public long getUptimeMillis() | ||
| { | ||
| return Duration.between(startupInstant, Instant.now()).toMillis(); |
There was a problem hiding this comment.
Wouldn't this calculation be wrong twice a year during DST changes?
There was a problem hiding this comment.
Yes, but in order to fix this we would need to know the ZoneId.
We could use ZoneId.systemDefault(), and modernize Server to have a ZonedDateTime as startup "time", rather than just Instant.
If users want to configure a different timezone for the JVM, they can use the system property user.timezone.
Now the startupTime is a ZonedDateTime, which takes into account daylight savings. Signed-off-by: Simone Bordet <[email protected]>
lorban
previously approved these changes
Oct 30, 2025
| } | ||
|
|
||
| @ManagedAttribute("The UTC startup instant") | ||
| @ManagedAttribute("The startup date time in the system timezone") |
There was a problem hiding this comment.
This is a somewhat breaking change, although not necessarily a bad one.
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.