Override "process.send" with a mock #5904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a mock object for `process`, `process.send` is just referenced from the parent context, which means that a test has access to the real IPC channel established by `jest-worker`, thus breaking the sandbox. As per the Node definition, `process.send` is not defined if the Node process hasn't started off a `fork` call; but this shouldn't be an issue because `send` has always been exposed and no one complained so far 🙃
cpojer
approved these changes
Mar 30, 2018
Member
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
- Maybe test this somehow?
- It's a company holiday today, don't work too much.
SimenB
reviewed
Mar 30, 2018
| } | ||
|
|
||
| newProcess.env = createProcessEnv(); | ||
| newProcess.send = () => {}; |
Member
There was a problem hiding this comment.
Any other functions on it while we're here?
Contributor
Author
There was a problem hiding this comment.
I've thought about it and I don't think so. Maybe newProcess.exit, but I thougth it was better to let it exit.
Member
There was a problem hiding this comment.
Might be cool to log a "process.exit() called from test" or something, potentially with a stack. Rarely on purpose, is it?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a mock object for
process,process.sendis just referenced from the parent context, which means that a test has access to the real IPC channel established byjest-worker, thus breaking the sandbox.As per the Node definition,
process.sendis not defined if the Node process hasn't started off aforkcall; but this shouldn't be an issue, becausesendhas always been exposed and no one complained so far 🙃This should also fix #5891.