Skip to content

fix: call custom resolver with node.js modules #12654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2022
Merged

fix: call custom resolver with node.js modules #12654

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06347b2
fix: call custom resolver with node.js modules
ChocolateLoverRaj Apr 8, 2022
0213fa3
Apply suggestions from code review
SimenB Apr 9, 2022
37b7a7d
Update CHANGELOG.md
SimenB Apr 9, 2022
370e47d
snaps
SimenB Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/jest-resolve/src/__tests__/resolve.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,21 @@ describe('resolveModule', () => {
expect(resolvedWithSlash).toBe(fooSlashIndex);
expect(resolvedWithSlash).toBe(resolvedWithDot);
});

it('custom resolver can resolve node modules', () => {
userResolver.mockImplementation(() => 'module');

const moduleMap = ModuleMap.create('/');
const resolver = new Resolver(moduleMap, {
extensions: ['.js'],
resolver: require.resolve('../__mocks__/userResolver'),
} as ResolverConfig);
const src = require.resolve('../');
resolver.resolveModule(src, 'fs');

expect(userResolver).toHaveBeenCalled();
expect(userResolver.mock.calls[0][0]).toBe('fs');
});
});

describe('resolveModuleAsync', () => {
Expand Down
6 changes: 3 additions & 3 deletions packages/jest-resolve/src/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ export default class Resolver {
// ignore all modules that look like node modules (ie. are not relative
// requires). This enables us to speed up resolution when we build a
// dependency graph because we don't have to look at modules that may not
// exist and aren't mocked.
// exist and aren't mocked.waq
const resolveNodeModule = (name: string, throwIfNotFound = false) => {
if (this.isCoreModule(name)) {
if (this.isCoreModule(name) && !this._options.resolver) {
return name;
}

Expand Down Expand Up @@ -292,7 +292,7 @@ export default class Resolver {
// dependency graph because we don't have to look at modules that may not
// exist and aren't mocked.
const resolveNodeModule = async (name: string, throwIfNotFound = false) => {
if (this.isCoreModule(name)) {
if (this.isCoreModule(name) && !this._options.resolver) {
return name;
}

Expand Down