fix(runner): handle module loaders with default exports #10541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Sep 21, 2020
| require(testEnvironment), | ||
| ).default; | ||
| const testFramework: TestFramework = | ||
| const testFramework: TestFramework = interopRequireDefault( |
Member
Author
There was a problem hiding this comment.
can use import() here with built-in interop, but that creates extra promises 🤷 Also not sure if that works with real ESM
This was referenced Nov 17, 2020
This was referenced Mar 28, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Useful for people with custom runtimes (a la #10540 (comment))
Test plan
Green CI