fix: Bumps node-notifier to v8.0.0 #10400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Aug 13, 2020
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
thanks! mind adding an entry to the changelog as well?
Contributor
Author
|
Added it now, marked as a fix and linking to this PR |
SimenB
changed the title
This was referenced Dec 17, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue with Linux systems and node-notifier dependency (#9701). This PR bumps node-notifier to v8.0.0 which should fix these issues. Should get the people experiencing issues to confirm.
cc @millette @mpareja
Fixes #9701
Test plan
Shouldn't be any changes other than patch fix for Jest usage. Timeout for Linux systems will change, but no API changes. Types definitions on definitely typed aren't updated, but it is inconsequential for this PR as I see it.