Since Jest 23.2.0: "Coverage data for global was not found."

[Vinnl]

🐛 Bug Report

This is going to be somewhat of a difficult bug report since there's many moving parts and I'm not sure which causes it, but since upgrading Jest from 23.1.0 to 23.2.0, I'm currently running into the following error on one of my projects:

=============================== Coverage summary ===============================
Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )
================================================================================
Jest: Coverage data for global was not found.

Apart from the upgrade (which did encompass quite a few packages to be upgraded along with jest proper), nothing changed in my setup.

I'm using TypeScript with ts-jest, if relevant.

To Reproduce

$ git clone -b deps/update-46517a0f git@gitlab.com:Flockademic/Flockademic.git
$ yarn
$ yarn run jest

Unfortunately I wouldn't know how to reproduce this in a fresh repo...

Expected behavior

Tests to succeed (which is happening now) and coverage to be 100% everywhere.

Link to repl or repo (highly encouraged)

Not minimal unfortunately, but as I referenced above: git clone -b deps/update-46517a0f git@gitlab.com:Flockademic/Flockademic.git.

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: Linux 4.13 Ubuntu 16.04.4 LTS (Xenial Xerus)
    CPU: x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Binaries:
    Node: 8.10.0 - ~/.nvm/versions/node/v8.10.0/bin/node
    Yarn: 1.7.0 - /usr/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.10.0/bin/npm
  npmPackages:
    @types/jest: 23.1.1 => 23.1.1
    jest: 23.2.0 => 23.2.0

[palmerj3]

@Vinnl I suspect that this is due to ts-jest not being compatible with jest 23. There is an issue on the ts-jest repo to investigate compatibility. kulshekhar/ts-jest#589

[TheCodeDestroyer]

@palmerj3 I don't use types and I get the same error

Sent from my Nexus 5X using FastHub

[Rukeith]

I got the same issue and I just use pure javascript.

[AodhanHayter]

I'm having the same issue, dropping down to jest@22.4.4 resolves the issue. Any version at 23.x.x gives me the same problem. Maybe config options have changed?

[Rukeith]

I notice 23.x.x add a options --coverage, but it still not work while I add to command line.

[jongear]

With pure javascript, I also received the Jest: Coverage data for global was not found. error in jest@23.3.0

package.json for reference

 {
  "name": "my-package",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "test": "jest",
    "test:coverage": "jest --coverage",
    "report-coverage": "npm run test:coverage && cat ./coverage/lcov.info | codecov",
  },
  "jest": {
    "coverageThreshold": {
      "global": {
        "branches": 50,
        "functions": 50,
        "lines": 50,
        "statements": 50
      }
    },
    "collectCoverageFrom": [
      "src/**/*.{js}",
      "!**src/config/*.{js}",
      "!**src/config/*/*.{js}",
      "!**src/docs/*.{js}",
      "!**src/models/*.{js}"
    ]
  },
  "devDependencies": {
    "codecov": "^3.0.3",
    "eslint": "^4.19.1",
    "eslint-config-prettier": "^2.9.0",
    "eslint-plugin-prettier": "^2.6.2",
    "jest": "^23.3.0",
    "prettier": "^1.13.7"
  }
}

For now, we have rolled back to jest@22.4.3 which works as expected

[Tvrqvoise]

I've found the issue. As part of #6400, micromatch was upgraded from version ^2.3.11 to ^3.1.10. Between these major versions, micromatch appears to have more closely adhered to Unix glob, which means breaking changes. Jest uses this library for matching the configuration values in package.json such as collectCoverageFrom, and hence some configurations which worked previously will no longer work.

For example, @jongear, in micromatch@2 you could do something like src/**/*.{js}. However, in micromatch@3 single-item sets are invalid and must now be either src/**/*.js or src/**/*.{js,}. Likewise, the same problem exists in @Vinnl's library -- lib/lambda/faas.ts is matched by lib/**.{js,ts} in micromatch@2, but must be lib/**/*.{js,ts} in micromatch@3.

I'll open a PR to revert micromatch back down to version 2. Not sure if FB wants to go down this route or not, but at least it's something -- someone on the Jest team should probably advise.

In the meantime, individuals can fix their issue by assuring that your glob patterns work in version 3.

[Vinnl]

That's fantastic @Tvrqvoise, I don't know how you managed to track that down, but I can confirm that updating the glob patterns fixed it for me.

Although micromatch@3 is a year old now apparently, its CHANGELOG does mention that there should be no breaking changes. I guess this change does look reasonable, but if it would be reason for Jest to downgrade to v2, then maybe we should report it as an issue there as well?

[thymikee]

I think we should file a PR to the changelog within micromatch then. @Vinnl would be so kind?

[SimenB]

I'm open to a revert, then upgrade it for Jest 24 along with the awesome explanation @Tvrqvoise provided about the gotchas. It's obviously super breaking, and landed in a minor (#6400).