jsdom version restriction is too loose, given the eval hacks

[domenic]

The jsdom version restriction is at "^6.1.0". However, given that you are relying on private jsdom APIs which could change in any patch release, this is not appropriate. Instead you should pin to a specific patch release (e.g. "6.1.0") and only do upgrades after verifying that the private API you are depending on has not been changed. (Or, you should stop poking around jsdom's internals.)

[cpojer]

Good point. Maybe one day we can stop using internal APIs :)

[Sebmaster]

@cpojer I just looked into this a bit and... I might overlook something big here, but wouldn't window.eval just work for this use-case? Can you look into this to see if this allows you to avoid our internal API usage?

[cpojer]

cc @DmitrySoshnikov why are we using runInContext here?

[Sebmaster]

Seems like this came up during the iojs upgrade, I'm not sure why eval was overlooked back then though.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.