Function.prototype.bind: incorrect behaviour of ecma_gc_mark() #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerry-core/ecma/base/ecma-gc.cpp
Outdated
There was a problem hiding this comment.
Object in a [[TargetFunction]] property also need to be marked as visited.
There was a problem hiding this comment.
You're right, I've fixed it. Thanks.
|
Looks good to me |
|
LGTM. Is it possible to add a test? |
|
I think it isn't possible, because we can't externally control the behaviour of the GC. |
|
@egavrin Can we merge this PR? |
Closed
|
See also: #622 |
bzsolt
force-pushed
the
fix_issue_531
branch
from
9b08bdb to
10f4f9a
Compare
Related issue: jerryscript-project#531 JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
bzsolt
force-pushed
the
fix_issue_531
branch
from
10f4f9a to
6697523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #531
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]