Fix: avoid 1B OOB read at EOF after class static block (Fixes #5254) #5261
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript-project#5254) When a class static block ends at EOF (no trailing newline), the caller unconditionally consumed the next char after '}', causing a 1-byte OOB read in lexer_consume_next_character. Guard at the call site and raise the same parse error the next stage expects. JerryScript-DCO-1.0-Signed-off-by: Harriet Zhu [email protected]
seanshpark
reviewed
Oct 22, 2025
| fields_size += sizeof (scanner_location_t); | ||
|
|
||
| lexer_consume_next_character (context_p); | ||
|
|
seanshpark
reviewed
Oct 22, 2025
Comment on lines
+865
to
+868
| else | ||
| { | ||
| lexer_consume_next_character (context_p); | ||
| } |
There was a problem hiding this comment.
maybe we don't need else as parser_raise_error will stop the execution.
Suggested change
| else | |
| { | |
| lexer_consume_next_character (context_p); | |
| } | |
| lexer_consume_next_character (context_p); |
|
|
seanshpark
reviewed
Oct 22, 2025
|
|
||
| lexer_consume_next_character (context_p); | ||
|
|
||
| if (JERRY_UNLIKELY(context_p->source_p >= context_p->source_end_p)) |
There was a problem hiding this comment.
Suggested change
| if (JERRY_UNLIKELY(context_p->source_p >= context_p->source_end_p)) | |
| if (JERRY_UNLIKELY (context_p->source_p >= context_p->source_end_p)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class static block ends at EOF (no trailing newline), the caller unconditionally consumed the next char after '}', causing a 1-byte OOB read in lexer_consume_next_character. Guard at the call site and raise the same parse error the next stage expects.
JerryScript-DCO-1.0-Signed-off-by: Harriet Zhu [email protected]
PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING