Add support for URI encoding / decoding. #177
Conversation
zherczeg
force-pushed
the
uri_devel
branch
2 times, most recently
from
d90f518 to
7c343a3
Compare
egavrin
added
ecma builtins
| } | ||
|
|
||
| ecma_string_to_zt_string (input_string_p, | ||
| input_start_p, (ssize_t) buffer_size); |
There was a problem hiding this comment.
Third parameter should be also on its own line.
|
I hope I fixed everything and use MEM_DEFINE_LOCAL_ARRAY for local memory allocation. Is there anything else? |
| ecma_builtin_global_object_hex_to_byte (ecma_char_t *source_p) /**< source string */ | ||
| { | ||
| uint32_t decoded_byte = 0; | ||
| int i; |
There was a problem hiding this comment.
I think we can i declaration into for header.
|
@zherczeg seams OK. I have the only request: Please, add comments inside the function that describes the logic behind. |
|
Well, there are very few comments inside function bodies in Jerry. I just followed the current style. |
|
Everything is done. |
| character = (character << 6) + (decoded_byte & 0x3f); | ||
| input_char_p += 3; | ||
| } | ||
| while (--count > 0); |
There was a problem hiding this comment.
AFAIK: the correct style would be to have the while on the same line as the closing bracket.
There was a problem hiding this comment.
I checked the source but it seems do-while is used this way.
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
|
Patch was updated. |
|
lgtm |
|
|
|
thank you |
|
Rebased & merged: 6027906 |
Add URI encoding/decoding to global object.
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]