Use __func__ instead of __FUNCTION__ #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __FUNCTION__ is not part of the C99/C++11 standard. So replace all occurrences with the standard __func__. Side note: GCC 5.1 warns when using -Wpedantic -std=c99 and __FUNCTION__. JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
|
Looks good to me |
|
Good to me. |
|
Merged |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FUNCTION is not part of the C99/C++11 standard.
So replace all occurrences with the standard func.
Side note: GCC 5.1 warns when using -Wpedantic -std=c99
and FUNCTION.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]