Mention slight inconsistency vs rjson::toJSON #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are many differences between rjson and jsonlite, they use a completely different mappings. I don't think mentioning this one detail about rjson behavior is very helpful. Perhaps it would make sense to define a wrapper function which tries to mimic the rjson default behavior. |
|
Do you agree that calling it a "drop-in replacement" is problematic? I'm
open to other solutions
…On Sat, Feb 27, 2021, 5:35 AM Jeroen Ooms ***@***.***> wrote:
There are many differences between rjson and jsonlite, they use a
completely different mappings. I don't think mentioning this one detail
about rjson behavior is very helpful...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#349 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BA5KYZ2RP4LWUFBN2ZWDTBDYKZANCNFSM4YJCNFMQ>
.
|
jeroen
force-pushed
the
master
branch
8 times, most recently
from
e43a8f6 to
89a3e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #348