Add support for delayed load of dbghelp #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dbghelp is a large library and is known to increase startup times when loaded as a dll. When using /DELAYLOAD windows will automatically load the library on the first call to one of its functions.
|
Not sure if this should be default ON or OFF. |
jeremy-rifkin
approved these changes
Sep 17, 2025
| @@ -276,6 +276,11 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang") | |||
| SET(CMAKE_CXX_ARCHIVE_FINISH "<CMAKE_RANLIB> -no_warning_for_no_symbols -c <TARGET>") | |||
| endif() | |||
|
|
|||
| if(CPPTRACE_DELAYLOAD_DBGHELP AND BUILD_SHARED_LIBS AND MSVC) | |||
There was a problem hiding this comment.
I think this should also check if we're actually using dbghelp, i.e. CPPTRACE_UNWIND_WITH_DBGHELP OR CPPTRACE_GET_SYMBOLS_WITH_DBGHELP OR CPPTRACE_DEMANGLE_WITH_WINAPI. Unfortunately it'll be a bit of a nasty condition :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dbghelp is a large library and is known to increase startup times when loaded as a dll. When using /DELAYLOAD windows will automatically load the library on the first call to one of its functions.