-
Notifications
You must be signed in to change notification settings - Fork 76
update the default import map paths #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes involve formatting adjustments and the addition of new entries to the Changes
Sequence Diagram(s)sequenceDiagram
participant A as Developer
participant B as src/constants.js
participant C as Application
A->>B: Update import paths
B->>C: Provide new import paths
C->>B: Request import paths
B-->>C: Return updated paths
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/constants.js (1 hunks)
Additional comments not posted (7)
src/constants.js (7)
24-24
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
26-26
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
27-27
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
28-28
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
29-29
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
31-31
: Approved: The formatting change improves code readability.The entry is formatted to be on a single line, which is consistent with the formatting of other entries in the object.
32-39
: Approved: The addition of new entries expands the available import paths for the applications.The new entries for various applications like
@jembi/clients-app
,@jembi/dashboard-app
, etc., are added to theDEFAULT_IMPORT_MAP_PATHS
object. The entries follow the same format as the existing entries in the object and are consistent with the AI-generated summary and the list of alterations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
- Coverage 87.25% 86.77% -0.49%
==========================================
Files 90 90
Lines 6040 6040
==========================================
- Hits 5270 5241 -29
- Misses 770 799 +29 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit