PLAT-707 Add kafka integration #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
+ Coverage 86.56% 86.65% +0.09%
==========================================
Files 85 87 +2
Lines 5806 5876 +70
==========================================
+ Hits 5026 5092 +66
- Misses 780 784 +4
|
marrouchi
suggested changes
Apr 14, 2023
rcrichton
reviewed
Apr 16, 2023
…,201 etc would be ignored
… needed, rather than all on server startup
…wo producers with the same clientId in different channels don't conflict.
…fka routes will use
…e folder as it is not a middleware and placed it in the root instead
…07-kafka-integration
…tion if a kafka route is the primary route
…-core-js into PLAT-707-kafka-integration
…-core-js into PLAT-707-kafka-integration
…tting the response metrics on the route
…catch since parseInt does not throw but instead returns NaN if it fails to parse. Add tests to cover the new logic
…-core-js into PLAT-707-kafka-integration
This reverts commit 2b63df6.
rcrichton
previously approved these changes
May 18, 2023
marrouchi
suggested changes
May 23, 2023
marrouchi
approved these changes
May 23, 2023
marrouchi
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.